Difference between revisions of "How To Write Unit Tests For OpenSSL"
(Created page with "This is an outline of the basic process and principles to follow when writing unit tests. This document will evolve quite a bit as the community gains experience. == Forking the…") |
|||
Line 9: | Line 9: | ||
[http://mike-bland.com/2014/06/05/pseudo-xunit-pattern.html The Pseudo-xUnit Pattern] is that established by [http://git.openssl.org/gitweb/?p=openssl.git;a=blob;f=ssl/heartbeat_test.c ssl/heartbeat_test.c]. This pattern organizes code in a fashion reminiscent of the [http://en.wikipedia.org/wiki/XUnit xUnit] family of unit testing frameworks, without actually using a testing framework. This should lower the barrier-to-entry to people wanting to write unit tests, but enable a relatively easy migration to an xUnit-based framework if we decide to do so one day. | [http://mike-bland.com/2014/06/05/pseudo-xunit-pattern.html The Pseudo-xUnit Pattern] is that established by [http://git.openssl.org/gitweb/?p=openssl.git;a=blob;f=ssl/heartbeat_test.c ssl/heartbeat_test.c]. This pattern organizes code in a fashion reminiscent of the [http://en.wikipedia.org/wiki/XUnit xUnit] family of unit testing frameworks, without actually using a testing framework. This should lower the barrier-to-entry to people wanting to write unit tests, but enable a relatively easy migration to an xUnit-based framework if we decide to do so one day. | ||
− | + | == Use the Test Template Generator == | |
− | Until we solve the private-symbol problem on Windows, we will need to wrap our unit test code in the following | + | TODO(mbland): Get template generator checked-in. Maybe have a template generator for each library, e.g. <code>ssl/new-test.c</code> that has additional setup boilerplate specific to the <code>ssl</code> library. |
+ | |||
+ | Use the <code>test/new-test.sh</code> script to generate a skeleton test file. | ||
+ | |||
+ | Until we solve the private-symbol problem on Windows, we will need to wrap our unit test code in the following <code>#ifdef</code> block: | ||
+ | <pre> | ||
+ | #if !defined(OPENSSL_SYS_WINDOWS) | ||
+ | |||
+ | /* All the test code, including main() */ | ||
+ | |||
+ | int main(int argc, char *argv[]) | ||
+ | { | ||
+ | return EXIT_SUCCESS; | ||
+ | } | ||
+ | |||
+ | #endif /* OPENSSL_NO_WINDOWS */ | ||
+ | </pre> |
Revision as of 14:45, 6 June 2014
This is an outline of the basic process and principles to follow when writing unit tests. This document will evolve quite a bit as the community gains experience.
Forking the Repo
For now, people contributing new unit tests for uncovered code (as opposed to submitting tests with new code changes) should fork Mike Bland's GitHub repository and issue GitHub pull requests. Remember to do all development on a topic branch (not master
). Tests committed to this repo will occasionally get merged into the master OpenSSL repo.
Rationale per Matt Caswell: We should think about process here. If you are going off to recruit an army of people writing tests then I wonder if it is worth setting up a separate github repository whilst you are building up the tests. We can then merge in from that on a periodic basis. I wouldn't want availability of openssl team committers to be a bottle neck.
Follow Pseudo-xUnit Style
The Pseudo-xUnit Pattern is that established by ssl/heartbeat_test.c. This pattern organizes code in a fashion reminiscent of the xUnit family of unit testing frameworks, without actually using a testing framework. This should lower the barrier-to-entry to people wanting to write unit tests, but enable a relatively easy migration to an xUnit-based framework if we decide to do so one day.
Use the Test Template Generator
TODO(mbland): Get template generator checked-in. Maybe have a template generator for each library, e.g. ssl/new-test.c
that has additional setup boilerplate specific to the ssl
library.
Use the test/new-test.sh
script to generate a skeleton test file.
Until we solve the private-symbol problem on Windows, we will need to wrap our unit test code in the following #ifdef
block:
#if !defined(OPENSSL_SYS_WINDOWS) /* All the test code, including main() */ int main(int argc, char *argv[]) { return EXIT_SUCCESS; } #endif /* OPENSSL_NO_WINDOWS */